Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Redesign dropdown #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FE: Redesign dropdown #387

wants to merge 1 commit into from

Conversation

svrmnk
Copy link
Contributor

@svrmnk svrmnk commented May 14, 2024

What changes did you make? (Give an overview)

Fixes #312

I redesigned dropdowns including select and multiselect components.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@svrmnk svrmnk requested a review from a team as a code owner May 14, 2024 07:28
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi svrmnk! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@svrmnk svrmnk changed the title feat: add redesign of dropdown issue 312: add redesign of dropdown May 14, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/refactor Refactoring task area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels May 14, 2024
@Haarolean Haarolean self-assigned this May 14, 2024
@svrmnk
Copy link
Contributor Author

svrmnk commented May 15, 2024

@Haarolean, please let me know when there are any updates)

@Haarolean Haarolean changed the title issue 312: add redesign of dropdown FE: Redesign dropdown May 16, 2024
@svrmnk
Copy link
Contributor Author

svrmnk commented May 23, 2024

@Haarolean Can you tell me if you need any help? Maybe there are some problems?

@Haarolean
Copy link
Member

We'll get to review this once I get some spare time

@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experiense issues hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign dropdown
2 participants